Reorder Jacobian calculation #707
Draft
+160
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The computational benefit of using this PR is around 10% for some functions and we decide not to pursue it further since the failing tests are unclear to us and the benefit is not a lot. |
|
@mattldawson sorry I am wrong here. This PR is crucial to achieving the impressing performance from nvhpc and gcc compilers. I would like to see if we can resolve the failed integration tests and merge in this PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorders the Jacobian calculation to be column-wise instead of random. This should be most useful with CSC ordering. In draft until the failing integration tests for certain analytical cases can be evaluated.